search

platformio / platform-atmelavr

Atmel AVR: development platform for PlatformIO
https://registry.platformio.org/platforms/platformio/atmelavr
Apache License 2.0
138 stars 105 forks source link

Boards.h file doesn't have ATMega1284P or ATMega1284 defined for Sanguino #109

Closed Maddog2050 closed 5 years ago

Maddog2050 commented 5 years ago

Hi,

I have found that the Boards.h file doesn't have a definition for the ATMega1284P or ATMega1284 for the Sanguino boards as I got the error below:

In file included from C:\Users\auser.platformio\packages\framework-arduinoavr\libraries\Firmata\Firmata.h:17:0, from C:\Users\auser.platformio\packages\framework-arduinoavr\libraries\Firmata\Firmata.cpp:18: C:\Users\Auser.platformio\packages\framework-arduinoavr\libraries\Firmata\Boards.h:770:2: error: #error "Please edit Boards.h with a hardware abstraction for this board"

error "Please edit Boards.h with a hardware abstraction for this board"

Please could you update the Boards.h file so that the Sanguino definition also includes the ATMega1284P or ATMega1284 as per the below.

// Sanguino
#elif defined(__AVR_ATmega644P__) || defined(__AVR_ATmega644__) || defined(__AVR_ATmega1284P__) || defined(__AVR_ATmega1284__)

Thanks

Adam

ivankravets commented 5 years ago

Please move issue to https://github.com/firmata/arduino