platformio / platform-atmelmegaavr

Atmel megaAVR: development platform for PlatformIO
https://registry.platformio.org/platforms/platformio/atmelmegaavr
Apache License 2.0
28 stars 21 forks source link

tool-avrdude not installed correctly if needed #56

Closed maxgerhardt closed 1 year ago

maxgerhardt commented 1 year ago

Although there is

https://github.com/platformio/platform-atmelmegaavr/blob/8b0b41feb9dccf14b53348aae9b76c8eead258b8/platform.py#L49-L53

there is tool-avrdude package definition in the platform.json

https://github.com/platformio/platform-atmelmegaavr/blob/8b0b41feb9dccf14b53348aae9b76c8eead258b8/platform.json#L28-L65

which I think leads to the problem posted about in

https://community.platformio.org/t/tool-avrdude-error-cannot-build-example-hello-world-code-due-to-the-tool-failing/32645?u=maxgerhardt

maxgerhardt commented 1 year ago

The PR fixed the issue correctly per https://community.platformio.org/t/tool-avrdude-error-cannot-build-example-hello-world-code-due-to-the-tool-failing/32645/8?u=maxgerhardt.