search

platformio / platform-atmelsam

Atmel SAM: development platform for PlatformIO
https://registry.platformio.org/platforms/platformio/atmelsam
Apache License 2.0
82 stars 108 forks source link

Add support for Teknic ClearCore #215

Open patrickwasp opened 1 year ago

patrickwasp commented 1 year ago

Closes https://github.com/platformio/platform-atmelsam/issues/175.

maxgerhardt commented 1 year ago

Also: Your changes can be automatically verified to be compiling successfully on all architectures if you add an environment for your board in one of the examples, e.g., to examples/arduino-blink/platformio.ini at the bottom:

[env:clearcore]
platform = atmelsam
board = clearcore
framework = arduino

This example gets auto-compiled in the Github CI (see .github/workflows).

maxgerhardt commented 1 year ago

Can you go in your repo's https://github.com/patrickwasp/platform-atmelsam/actions and click activate? You should get compile feedback then (because CI will only run here after someone approves it)

patrickwasp commented 1 year ago

Can you go in your repo's https://github.com/patrickwasp/platform-atmelsam/actions and click activate? You should get compile feedback then (because CI will only run here after someone approves it)

I enabled it but the git action doesn't have workflow_dispatch so I can't manually run it.

maxgerhardt commented 1 year ago

It should automatically triger in each commit (after it's been enabled), so the next commit will trigger it.

Something that'll come up in review is also that last empty line was removed

grafik

(both .ini and in the arduino py file.). So you can just add another empty newline at the end of those files and commit that. (Somtimes you have to put two empty newlines because git likes to strip one)

maxgerhardt commented 1 year ago

Very nice, it built the clearcore firmware in the CI succesfully: https://github.com/patrickwasp/platform-atmelsam/actions/runs/6001903149/job/16277089103

I oversaw the missing newline end in the boards/clearcore.json though, but that'll all then.

CiberNin commented 1 month ago

Is there anything holding this PR back?

Arduino just dropped support for its VSCode extension, so there's a bit more demand for this package to support the board.