search

platformio / platform-espressif32

Espressif 32: development platform for PlatformIO
https://registry.platformio.org/platforms/platformio/espressif32
Apache License 2.0
901 stars 609 forks source link

Updated some UM boards info #1315

Closed UnexpectedMaker closed 1 month ago

UnexpectedMaker commented 7 months ago

Also renamed tinypico to um_tinypico to match all of the UM board naming. These have been named this way in Arduino for a long time now.

valeros commented 7 months ago

Hi @UnexpectedMaker, thanks for the PR. The name of the manifest file plays an important role as a board ID in project configurations. It means that your simple renaming tinypico.json to um_tinypico.json may break already configured projects. If you insist on renaming, I'd recommend keeping both files tinypico.json an um_tinypico.json, but the name of the board in the tinypico.json file may contain a phrase like Unexpected Maker TinyPICO (deprecated in favor of "um_tinypico"), so that it can be safely removed in a new major release.

UnexpectedMaker commented 7 months ago

@valeros Oh, that's a really good point. I'll revert this change later today, and leave it as is.

stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. Please provide more details or it will be closed if no further activity occurs. Thank you for your contributions.