platformio / platform-intel_mcs51

Intel MCS-51 (8051): development platform for PlatformIO
https://registry.platformio.org/platforms/platformio/intel_mcs51
Apache License 2.0
56 stars 45 forks source link

adding support for stc15f208ea and stc15w408as mcus #4

Closed zerog2k closed 6 years ago

zerog2k commented 6 years ago

@Palatis & @ivankravets please review

Palatis commented 6 years ago

can I kindly ask you to:

  1. add a platformio package for stcgal so it automatically find + download + install the required tools?
  2. split Palatis => platformio to another merge request? I know this is a bit annoying, but that keeps the merge history clean.
zerog2k commented 6 years ago

@Palatis ok, maybe you can help me understand the options for item 1. Stcgal is provided as python3 repo at the moment. Currently, I'm including this as a submodule in my existing project repos (and referencing it directly with my older makefile patterns.) I'm not sure what the best way to "package" this w/ platformio in some crossplatform way. Could it be a simple submodule repo of the platform-mcs51, or should it be in a separate tools repo? (I'm just getting my head around the platformio stuff ;)

ivankravets commented 6 years ago

@zerog2k

maybe you can help me understand the options for item 1. Stcgal is provided as python3 repo at the moment.

I'll add it, I saw it in your repo :)

zerog2k commented 6 years ago

ok thanks @Palatis @ivankravets i have tried rebasing to master and updating... hope i didnt mangle it up too much.. (Not sure if you guys just do squash merge anyhow)

zerog2k commented 6 years ago

Thanks @ivankravets I'm not sure if i mentioned it - the stcgal repo is at https://github.com/grigorig/stcgal

Palatis commented 6 years ago

we should also update the README file to point out that we support more boards now :-D

zerog2k commented 6 years ago

@Palatis updated readme and added one more stc mcu