search

platformio / platform-ststm32

ST STM32: development platform for PlatformIO
https://registry.platformio.org/platforms/platformio/ststm32
Apache License 2.0
407 stars 312 forks source link

Fix build for weact_mini_h750vbtx and weact_mini_h743vitx #695

Closed maxgerhardt closed 1 year ago

maxgerhardt commented 1 year ago

Fix for https://community.platformio.org/t/a-fresh-arduino-smt32h750-project-fails-to-build/33721?u=maxgerhardt.

PlatformIO doesn't generate the right identification macro for this board.

maxgerhardt commented 1 year ago

(CI fail was already there before me and is unrelated to the PR changes.)

valeros commented 1 year ago

Many thanks, merged!

s54b32julian commented 1 year ago

Maybe same problem with devebox_h743vitx? Get the exact same fault messages as in https://community.platformio.org/t/a-fresh-arduino-smt32h750-project-fails-to-build/33721?u=maxgerhardt , but can not fix it.

maxgerhardt commented 1 year ago

Yeah

https://github.com/platformio/platform-ststm32/blob/78196250d2256dda9c50edc5ad7049a050ad41ef/boards/devebox_h743vitx.json#L8

seems to be missing a board specific macro as well. Can you PR the right one in?

valeros commented 1 year ago

Thanks for pointing out, fixed in the dev branch.