search

platformio / platformio-atom-ide

PlatformIO IDE for Atom: The next generation integrated development environment for IoT
https://atom.io/packages/platformio-ide
Apache License 2.0
476 stars 72 forks source link

New atom core deprecation call on install #2527

Open camchaney opened 2 years ago

camchaney commented 2 years ago

Configuration

Operating system: MacOS Big Sur 11.6.2

PlatformIO Version: Core 5.2.4 IDE 2.7.2

Description of problem

After installing Platform IDE, I get a new deprecation in Atom.

Steps to Reproduce

  1. Uninstall PlatformIO from Atom (maybe unnecessary)
  2. Install platformio-ide in Atom package installer

Actual Results

A new deprecation results in Atom image

Atom Core Use require("electron").shell instead of require("shell")

Object. - /Applications/Atom.app/Contents/Resources/app.asar/exports/shell.js:4:6 Object. - /Applications/Atom.app/Contents/Resources/app.asar/exports/shell.js:9:3 Module._compile - :11:149891 Object..js - :11:153485 Module.load - internal/modules/cjs/loader.js:815:32 Module._load - internal/modules/cjs/loader.js:727:14

Expected Results

The package installs without any deprecations.

icecream17 commented 2 years ago

Linking to https://github.com/atom/atom/issues/22306

The import to be updated is at https://github.com/platformio/platformio-atom-ide/blob/develop/lib/utils.js#L19