platformio / platformio-core

Your Gateway to Embedded Software Development Excellence :alien:
https://platformio.org
Apache License 2.0
7.81k stars 787 forks source link

CLion: CMakeListsPrivate.txt missing src_build_flags #3137

Closed BirdAPI closed 4 years ago

BirdAPI commented 4 years ago

What kind of issue is this?

Configuration

Operating system: Windows 10 WSL

PlatformIO Version (platformio --version):

Description of problem

When generating CMake files from pio, the generated files do not add definitions for each of the src_build_flags and only the build_flags

Steps to Reproduce

source .platformio/venv/bin/activate && pio init --ide clion

Actual Results

if (CMAKE_BUILD_TYPE MATCHES "ttgo-display")
    add_definitions(-D'PLATFORMIO=40003')
    add_definitions(-D'ARDUINO_TTGO_LoRa32_V1')
    add_definitions(-D'CORE_DEBUG_LEVEL=ARDUHAL_LOG_LEVEL_VERBOSE')
    add_definitions(-D'LOG_LOCAL_LEVEL=ESP_LOG_DEBUG')
    add_definitions(-D'CONFIG_ARDUHAL_LOG_COLORS=1')
    add_definitions(-D'CONFIG_ARDUHAL_ESP_LOG=1')
    add_definitions(-D'CONFIG_AUTOSTART_ARDUINO=1')
    add_definitions(-D'DEBUG_DISABLED')
    add_definitions(-D'USER_SETUP_LOADED=1')
    add_definitions(-D'ST7789_DRIVER=1')
    add_definitions(-D'TFT_WIDTH=135')
    add_definitions(-D'TFT_HEIGHT=240')
    add_definitions(-D'CGRAM_OFFSET')
    add_definitions(-D'TFT_MISO=-1')
    add_definitions(-D'TFT_MOSI=19')
    add_definitions(-D'TFT_SCLK=18')
    add_definitions(-D'TFT_CS=5')
    add_definitions(-D'TFT_DC=16')
    add_definitions(-D'TFT_RST=23')
    add_definitions(-D'TFT_BL=4')
    add_definitions(-D'TFT_BACKLIGHT_ON=HIGH')
    add_definitions(-D'LOAD_GLCD=1')
    add_definitions(-D'LOAD_FONT2=1')
    add_definitions(-D'LOAD_FONT3=1')
    add_definitions(-D'LOAD_FONT4=1')
    add_definitions(-D'LOAD_FONT5=1')
    add_definitions(-D'LOAD_FONT6=1')
    add_definitions(-D'LOAD_FONT7=1')
    add_definitions(-D'LOAD_FONT8=1')
    add_definitions(-D'LOAD_GFXFF=1')
    add_definitions(-D'SPI_FREQUENCY=40000000')
    add_definitions(-D'SPI_READ_FREQUENCY=20000000')
    add_definitions(-D'SPI_TOUCH_FREQUENCY=2500000')
    add_definitions(-D'TFT_SLPIN=0x10')
    add_definitions(-D'TFT_DISPOFF=0x28')
    add_definitions(-D'ESP32')
    add_definitions(-D'ESP_PLATFORM')
    add_definitions(-D'F_CPU=240000000L')
    add_definitions(-D'HAVE_CONFIG_H')
    add_definitions(-D'MBEDTLS_CONFIG_FILE=\"mbedtls/esp_config.h\"')
    add_definitions(-D'ARDUINO=10805')
    add_definitions(-D'ARDUINO_ARCH_ESP32')
    add_definitions(-D'ARDUINO_VARIANT=\"ttgo-lora32-v1\"')
    add_definitions(-D'ARDUINO_BOARD=\"TTGO LoRa32-OLED V1\"')

Expected Results

Same as above, however with additional definitions for each item in src_build_flags

add_definitions(-D'TTGO_DISPLAY=1')
add_definitions(-D'INVERT_STATUS_LED=0')
add_definitions(-D'ADC_EN=14')
add_definitions(-D'ADC_PIN=34')
add_definitions(-D'BUTTON_1=35')
add_definitions(-D'BUTTON_2=0')

If problems with PlatformIO Build System:

The content of platformio.ini:

build_flags = ${esp32.build_flags}
              -D USER_SETUP_LOADED=1
              -D ST7789_DRIVER=1
              -D TFT_WIDTH=135
              -D TFT_HEIGHT=240
              -D CGRAM_OFFSET
              -D TFT_MISO=-1
              -D TFT_MOSI=19
              -D TFT_SCLK=18
              -D TFT_CS=5
              -D TFT_DC=16
              -D TFT_RST=23
              -D TFT_BL=4
              -D TFT_BACKLIGHT_ON=HIGH
              -D LOAD_GLCD=1
              -D LOAD_FONT2=1
              -D LOAD_FONT3=1
              -D LOAD_FONT4=1
              -D LOAD_FONT5=1
              -D LOAD_FONT6=1
              -D LOAD_FONT7=1
              -D LOAD_FONT8=1
              -D LOAD_GFXFF=1
              -D SPI_FREQUENCY=40000000
              -D SPI_READ_FREQUENCY=20000000
              -D SPI_TOUCH_FREQUENCY=2500000
              -D TFT_SLPIN=0x10
              -D TFT_DISPOFF=0x28

src_build_flags = ${esp32.src_build_flags}
                  -D TTGO_DISPLAY=1
                  -D INVERT_STATUS_LED=0
                  -D ADC_EN=14
                  -D ADC_PIN=34
                  -D BUTTON_1=35
                  -D BUTTON_2=0

Additional info

Tested with the latest develop branch build 4.1.0b4 and issue is still present

ivankravets commented 4 years ago

Please re-test with pio upgrade --dev.

BirdAPI commented 4 years ago

Working now. Thanks.