platformio / platformio-vscode-ide

PlatformIO IDE for VSCode: The next generation integrated development environment for IoT
https://marketplace.visualstudio.com/items?itemName=platformio.platformio-ide
Apache License 2.0
1.23k stars 196 forks source link

Peripherial view does not show 8bit addressBlocks #2586

Open evilmav opened 3 years ago

evilmav commented 3 years ago

When trying to add AVR peripherial view support to PIO debugger by providing SVD files converted from Atmel's atdf. PIO seems to not show anything in the peripherial view if the adressBlock is less then 4 bytes.

Consider this SVD ```xml Atmel ATmega1284P 8 8 read-write 0 0xff AC Analog Comparator 0x50 0x0 0x1 registers ACSR Analog Comparator Control And Status Register 0x0 read-write ACIS Analog Comparator Interrupt Mode Select bits [1:0] read-write true VAL_0x00 Interrupt on Toggle 0 VAL_0x01 Reserved 1 VAL_0x02 Interrupt on Falling Edge 2 VAL_0x03 Interrupt on Rising Edge 3 ACIC Analog Comparator Input Capture Enable [2:2] read-write ACIE Analog Comparator Interrupt Enable [3:3] read-write ACI Analog Comparator Interrupt Flag [4:4] read-write ACO Analog Compare Output [5:5] read-write ACBG Analog Comparator Bandgap Select [6:6] read-write ACD Analog Comparator Disable [7:7] read-write ```

Nothing gets shown in the view, but the register appears if addressBlock.size is set to 4 or more.

I'd be happy to debug, but although according to Community PIO Plus is supposed to be open source, I can not find the source of platformio-vscode-debug. Where is it published?

PS In case of a missing addressBlock, PIO fails with an extremely unhelpful "Cannot read property '0' of undefined"

maxgerhardt commented 3 years ago

At https://github.com/Rahix/atdf2svd/issues/25#issuecomment-858741454 I've posted a reference with 8-bit regsiters which works nicely per https://github.com/platformio/platform-ststm8/pull/38, see screenshots.

I'd be happy to debug, but although according to Community PIO Plus is supposed to be open source, I can not find the source of platformio-vscode-debug. Where is it published?

+1 on this. I thought I opened an issue about that long ago but I can't find it anymore. I'll open a separate issue for that.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. Please provide more details or it will be closed if no further activity occurs. Thank you for your contributions.

maxgerhardt commented 3 years ago

~ still valid ~

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. Please provide more details or it will be closed if no further activity occurs. Thank you for your contributions.

maxgerhardt commented 3 years ago

~still valid ~