platformplatform / PlatformPlatform

Alpha state. A platform designed for building enterprise-grade, multi-tenant products using Azure, .NET, React, TypeScript, Infrastructure as Code, etc.
https://platformplatform.github.io
MIT License
257 stars 26 forks source link

Refactor prerequisite checks in Developer CLI #576

Closed PavlovicDzFilip closed 2 months ago

PavlovicDzFilip commented 2 months ago

Summary & Motivation

Update the prerequisites configuration to be strongly typed in the Developer CLI, reducing boilerplate code and making the code more concise.

Checklist

tjementum commented 2 months ago

BTW... Please force push your changes. No need for one more commit ;)

PavlovicDzFilip commented 2 months ago

Nice one. Thanks. I made a few small comments.

Did you have any problems… or did you just see an opportunity for improvements?

The description mentions problems on Windows, but I don’t see anything specific to Windows? I’ve updated the title and PR description (I avoid using the term “we” and “this PR” when describing the changes as it goes into commit history).

It does not run on Windows correctly. So far, I've found these issues:

I have not stumbled upon other issues so far to run the project. However, when running the Aspire Host, I was not able to debug the system - the breakpoints did not attach. Any idea why?

Finally: is there any community Slack/Discord channel to join?

tjementum commented 2 months ago

OK. I have a few companies building on PlatformPlatform who are using Windows. But I believe the CLI is not used that much. I have, however, seen it work several times, so it’s weird that it does not behave consistently.

Finally: is there any community Slack/Discord channel to join? Could you try: https://join.slack.com/t/platformplatform/signup

PS: Feel free to convert this to "Ready for review".

Also... did you not get a request to sign the CLA? I had some problems, but please do it here: https://cla-assistant.io/platformplatform/PlatformPlatform

tjementum commented 2 months ago

Are there any other rules

I just merged your other pull request. We always rebase to get a nice Git commit graph, so please rebase and force push, and then I think it’s ready to be merged.

PS: I noticed that you signed the CLA in the closed pull request from yesterday. So, all good.

PavlovicDzFilip commented 2 months ago

Could you try: https://join.slack.com/t/platformplatform/signup

I am being asked for an @platformplatform.net email address, which I do not have.

tjementum commented 2 months ago

I am being asked for an @platformplatform.net email address, which I do not have.

Please try again. I just removed it (forgot to click save before).

PavlovicDzFilip commented 2 months ago

Please try again. I just removed it (forgot to click save before).

It is still the case. image

tjementum commented 2 months ago

Ahh... it's because Slack is adding @platformplatform.net back. I should change a setting. Try one last time.

Sorry for the inconvenience.

PavlovicDzFilip commented 2 months ago

Now I need an invite:

My email address is REDACTED image

tjementum commented 2 months ago

OK. It's because this feature is not supported by Slack.

But I created an invite link and wrapped in a nice looking url here: https://bit.ly/platformplatform-slack-invite.

Sorry I should have tested before I shared the links :)