platformsh-templates / laravel

Laravel template for Platform.sh.
23 stars 98 forks source link

Update to latest upstream. #42

Closed gilzow closed 1 year ago

gilzow commented 2 years ago

Description

Replaces all instances of cmd with commands in cron section of .platform.app.yaml

@thomasdiluccio and @chadwcarlson : I was unable to get this template to update successfully with template builder. From what I have been able to find, symfony/finder after version 6.0.X is no longer compatible with version 8.0.X of PHP. However, attempts to lock finder to 6.0.X caused other composer dependency resolving issues. The cleanest fix was to bump the php version in .platform.app.yaml to php:8.1. However, given I'm not as familiar with this template, want to make sure the two of you verify bumping to php 8.1 is 👍

Please drop a link to the issue here:

https://github.com/platformsh/template-builder/issues/653

Motivation and Context

cmd is deprecated and will be removed in later versions of the platform.sh service

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

Go over all the following list, and put an x in all the boxes that apply. If you're unsure about what any of these mean, don't hesitate to ask. We're here to help!

gilzow commented 2 years ago

Even though the initial check looks to have passed, the PR environment is throwing a 500 error and the log shows

In Application.php line 751:

  Class "BeyondCode\DumpServer\DumpServerServiceProvider" not found

Converting PR to draft status until we can investigate the issue.