search

platformsh / config-reader-python

Configuration reader library for Platform.sh hosting - Python version.
MIT License
7 stars 5 forks source link

`__getitem__` should raise KeyError if the key is not found #19

Open demosdemon opened 5 years ago

demosdemon commented 5 years ago

https://github.com/platformsh/config-reader-python/blob/7084bcd3692c92dd21d560dbe9f58a3d03051800/platformshconfig/config.py#L429

Crell commented 5 years ago

Alternatively we can refactor getitem out completely and just use @property methods, like we do in Node.Js. But then the error handling should still be made consistent to raise an exception on a missing value, not return None.