platformsh / config-reader-python

Configuration reader library for Platform.sh hosting - Python version.
MIT License
7 stars 5 forks source link

Revisions #6

Closed chadwcarlson closed 5 years ago

Crell commented 5 years ago

Mostly :+1:, just a few notes.

The only other thing I can think of is if we want to switch to separate accessor functions for properties rather than using the common accessor. (Node style rather than PHP style.) That's not a release blocker, I think, since it's not an API change; I defer to @NickAnderegg on what the more Pythonic answer is.

The repo still needs to be renamed, though.