search

platformsh / platformsh-magento2-configuration

☠ DEPRECATED
9 stars 33 forks source link

app/etc/env.php autocreated when compile option is run #19

Open waynetheisinger opened 8 years ago

waynetheisinger commented 8 years ago

Platformsh.php decides whether to install Magento or update Config settings based on the existence of app/etc/env.php - but in Magento 2.1.1 (the only version I've tested) this file will always exist at the point at which the test runs because Magento has already created it when the compile command was run.

177c10fae2c0b7d88d54170eaa31782efd66c030 seems to be the commit that introduced this problem - I think a simple check whether the env exists at this stage might be enough to fix it

waynetheisinger commented 8 years ago

Actually I'm not sure that a check on env.php is a good idea - env.php is particular to install so locally it will be different than on Platform so really it should be in .gitignore