Open erfanimani opened 6 years ago
https://github.com/platformsh/platformsh-magento2-configuration/blob/master/Platformsh.php#L471
It’s checking whether PLATFORM_ENVIRONMENT is equal to master.
PLATFORM_ENVIRONMENT
master
However, running echo $PLATFORM_ENVIRONMENT returns master-{some_platform_id}.
echo $PLATFORM_ENVIRONMENT
master-{some_platform_id}
Also, according to the docs, PLATFORM_BRANCH should be used instead; https://docs.platform.sh/development/variables.html#platformsh-environment-variables
PLATFORM_BRANCH
As far as I can see, isMasterBranch will always return false.
isMasterBranch
false
https://github.com/platformsh/platformsh-magento2-configuration/blob/master/Platformsh.php#L471
It’s checking whether
PLATFORM_ENVIRONMENTis equal tomaster.However, running
echo $PLATFORM_ENVIRONMENTreturnsmaster-{some_platform_id}.Also, according to the docs,
PLATFORM_BRANCHshould be used instead; https://docs.platform.sh/development/variables.html#platformsh-environment-variablesAs far as I can see,
isMasterBranchwill always returnfalse.