#20 - Fallback to NULL mail transport protocol if disabled

platformsh / symfonyflex-bridge

Bridge library for running Symfony Flex on Platform.sh

MIT License

30 stars 15 forks source link

#20 - Fallback to NULL mail transport protocol if disabled #21

Closed Aricura closed 5 years ago

Aricura commented 5 years ago

Avoid setting an invalid MAILER_URL if sending mails is disabled. Use the NULL transport protocol instead and fallback the host to localhost.

smtp://:25 --> null://localhost:25

Crell commented 5 years ago

Makes sense given #20, but then we need a test here as well to verify it.

Aricura commented 5 years ago

I added the test case to verify it. Please have a look and review the changes.

Crell commented 5 years ago

I'm not sure why Circle CI isn't kicking in here; possibly because this is a master->master merge? Not sure. I checked it out locally and the tests all pass, though. Thanks!