Missing population of `PLATFORM_VARIABLES`

platformsh / symfonyflex-bridge

Bridge library for running Symfony Flex on Platform.sh

MIT License

30 stars 15 forks source link

Missing population of `PLATFORM_VARIABLES` #6

Closed olivermack closed 6 years ago

olivermack commented 6 years ago

Hey,

it seems as if this package is missing the mapping of the PLATFORM_VARIABLES env variable which contains the other variables one can define in the platform.sh UI.

Is this intended or just missing? I'm happy to contribute that part if it's missing.

Cheers

Crell commented 6 years ago

Variables that are prefixed with env: are converted to environment variables automatically by the backend system. No user-space code is necessary for that.

Mapping non-env-prefixed variables to top level env vars would be unexpected and not the contract of the API.

Thanks for checking, though!

olivermack commented 6 years ago

Oh jeez... Didn't know that. Awesome, thanks for the fast feedback!

Just checked it and it works indeed 👍