plathrop / puppet-module-supervisor

Puppet module for configuring the supervisor daemon tool.
BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

accept parameters for class supervisor #18

Closed saz closed 12 years ago

plathrop commented 12 years ago

Sorry, really busy at the day job. Will review soon, I promise!

plathrop commented 12 years ago

This all looks good to me, I'm assuming you've tested it and it all runs good for you? The only thing I'd like is if we're going to add a bunch of parameters to the class, we really should take the time to put in a puppetdoc-style documentation block at the top so that we know what all the parameters mean.

saz commented 12 years ago

Like 8481296?

saz commented 12 years ago

Except the wrong port, everything looks good and is working fine.

plathrop commented 12 years ago

Beautiful.