Closed saz closed 12 years ago
This all looks good to me, I'm assuming you've tested it and it all runs good for you? The only thing I'd like is if we're going to add a bunch of parameters to the class, we really should take the time to put in a puppetdoc-style documentation block at the top so that we know what all the parameters mean.
Like 8481296?
Except the wrong port, everything looks good and is working fine.
Beautiful.
Sorry, really busy at the day job. Will review soon, I promise!