search

plathrop / puppet-module-supervisor

Puppet module for configuring the supervisor daemon tool.
BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

Rename loglevel to log_level #21

Closed scoates closed 12 years ago

scoates commented 12 years ago

loglevel is a reserved word (metaparameter) in Puppet http://docs.puppetlabs.com/references/2.7.9/metaparameter.html

The practical problem, here, is that if we pass a loglevel = "trace" (which is a legitimate log level in supervisor), puppet complains with:

err: Failed to apply catalog: Parameter loglevel failed: Invalid value "trace". Valid values are debug, info, notice, warning, err, alert, emerg, crit, verbose.

This patch simply changes loglevel to log_level. It is a BC break, but… well… it was already broken.

plathrop commented 12 years ago

Whoa, yeah that's totally borken. Thanks for finding this!