plathrop / puppet-module-supervisor

Puppet module for configuring the supervisor daemon tool.
BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

Added support for greater configuration of unix_http_server #48

Closed hamsolodev closed 9 years ago

hamsolodev commented 11 years ago

Added three params to supervisor class

unix_server_file    (default: /var/run/supervisor.sock)
unix_server_chmod   (default: undef)
unix_server_chown   (default: undef)

Example of use:

class {'supervisor':
  unix_server_chmod => '0770',
  unix_server_chown => 'root:admin',
}

Users belonging to 'admin' group are then able to interact with supervised processes without resorting to sudo.

andyshinn commented 11 years ago

I actually left this as a comment on the commit accidentally. But I'd love this ability in Puppet so I can allow my admin users to hit supervisorctl without sudo. :+1:

andyshinn commented 11 years ago

:+1: I merged this in andyshinn/puppet-module-supervisor/@b815c2a83751781553880d312f4e7802c98d7d8a and it works. I'd recommend creating a new feature branch for this and updating the spec test to test the params and the socket file permissions. A feature branch will make it easier for other to pull in and test the feature.

hamsolodev commented 11 years ago

There didn’t appear to be a pattern for me to follow to add new tests—I’m not very familiar with writing tests for puppet at all, something I mean to rectify once I come across some digestible documentation!

I ended up just using my fork, in the end :)

Have created a feature/unix_http_server branch rebased off upstream master branch.

skrings commented 10 years ago

@markhellewell Please rebase your branch against upstream/master and resolve conflicts. Also if you provide defaults which are not undef then these values should match the supervisor defaults so there is no unintended behavior change. And finally some tests would be great.

plathrop commented 9 years ago

Closing due to lack of activity. Feel free to rebase, etc., and reopen.