plathrop / puppet-module-supervisor

Puppet module for configuring the supervisor daemon tool.
BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

Add support for other program types #72

Closed bkg closed 9 years ago

bkg commented 10 years ago

I am hoping to add support for other supervisor program types like eventlistener and fcgi-program.

I have implemented this in a generic manner to allow for the eventlistener and fastcgi specific params to be appended to the .ini file as arbitrary key/value pairs. This provides flexibility without cluttering the supervisor::service attributes with program specific settings.

Here is a basic example that uses the memmon command from the superlance plugins:

supervisor::service { 'memmon':
  command => 'memmon -a 200MB -m someone@somewhere.com'
  type => 'eventlistener',
  ini_append => {
    events => 'TICK_60',
  },
}
plathrop commented 9 years ago

LGTM, but I'd like someone who runs in production to +1 this before I merge.

plathrop commented 9 years ago

Closing due to lack of response, feel free to reopen.

bkg commented 9 years ago

Hi, I'm definitely still interested in getting this merged. I have been running it in production awhile without any problems.

plathrop commented 9 years ago

I'll merge it then, for lack of objection - and if someone gets annoyed they can PR a revert :-)

bkg commented 9 years ago

Nice, much appreciated!