search

plathrop / puppet-module-supervisor

Puppet module for configuring the supervisor daemon tool.
BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

Allow service management to be optional. #76

Closed bobtfish closed 9 years ago

plathrop commented 10 years ago

:-1: It's called supervisor::service; it's meant to manage a service. If you just want a config file, use a file resource.

bobtfish commented 10 years ago

Ok, thanks, I'll fork and forge my own version which use useable / useful for building Docker containers!

fungusakafungus commented 10 years ago

I was thinking about separating ensure => present and ensure => running for this purpose. There's another issue concerning autostart which will probably interact with ensure => running. And there's a similar idea with implementing enabled for supervisor::service. I'm still not sure how to accommodate all the use cases.

bobtfish commented 10 years ago

That sounds good - I'm absolutely happy to change my patch and approach to work better for other people, as I'd rather not fork and go my own way - but if @plathrop is definitely not taking this feature in any form then that's also cool (and great to know rather than being left wondering) :)

plathrop commented 10 years ago

@fungusakafungus You are probably on the right track.

ensure => present could be for "configure supervisor, but don't manage the service" ensure => running and ensure => stopped for "configure supervisor and manage the service" endure => absent for "make sure service is stopped and configuration is cleaned up"

autostart is probably a separate parameter.

plathrop commented 10 years ago

@bobtfish Sorry if I came off as poo-poo'ing the feature, I see now I could have been clearer. I was actually objecting to the implementation more than the use case itself.

I don't consider my opinion as the controlling one in any way at this point as I have not been running this module in production for some time; I let the people who are using it guide evolution. So feel free to work with the active users to get a good implementation (or even merge the one I -1'd)

bobtfish commented 10 years ago

@plathrop no sweat - sorry if I came across as throwing my toys out the pram re forking :_)

I'm not gonna have any time to look at this in the next few days, but I'll definitely to loop back and have a second crack at this over the weekend!

plathrop commented 9 years ago

Closing for lack of activity, feel free to re-open at any time.