search

plathrop / puppet-module-supervisor

Puppet module for configuring the supervisor daemon tool.
BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

Allow service to not be controlled by Puppet #81

Closed ianburrell closed 9 years ago

ianburrell commented 10 years ago

Change the ensure => "present" state to not create the "service" resource. Which leaves the service uncontrolled by Puppet, and allows to be not controlled by Puppet.

ensure => "present": Create config and don't control service ensure => "running", ensure => "stopped": Create config and service with given ensure state. ensure => "absent": Stop service and remove config

The downside is that it changes the behavior of the default "present" state. I also changed the default state to "running" to preserve default behavior. For compatibility, it might make sense to leave behavior of "present" unchanged and create a new state for the uncontrolled behavior.

This is an implementation of feature proposed in #76.

plathrop commented 9 years ago

This looks good to me; changing the default sucks, but there's no better way to get this working.

I have no objections, but as per usual I will issue the disclaimer that I am not currently running this in prod, so should only be considered a +.5

plathrop commented 9 years ago

Closing based on lack of response. Feel free to reopen.