Need to reload platina-mk1 module when interface speed is modified under interface configuraration

[sandeep-dutta]

Observed that when speed of interfaces are updated under interface configuration file, even if networking & goes services are restart, the updated changes are not reflecting. Need to specifically reload platina-mk1 module along with goes & networking services to update the changes which should have been done when goes was restarted.

Also noticed that if an interface is port provisioned & you reboot the invader. The port provisioned interfaces are not up unless we explicitly reload platina-mk1 module.

Steps to reproduce

• Below is the interface config auto xeth3 iface xeth3 inet static address 10.0.3.29 netmask 255.255.255.0 pre-up ip link set $IFACE up pre-up ethtool -s $IFACE speed 100000 autoneg off pre-up ethtool --set-priv-flags $IFACE copper on pre-up ethtool --set-priv-flags $IFACE fec74 off pre-up ethtool --set-priv-flags $IFACE fec91 on post-down ip link set $IFACE down allow-vnet xeth3

• Change the speed of the interface to autoneg on auto xeth3 iface xeth3 inet static address 10.0.3.29 netmask 255.255.255.0 pre-up ip link set $IFACE up ethtool -s $IFACE autoneg on pre-up ethtool --set-priv-flags $IFACE copper on pre-up ethtool --set-priv-flags $IFACE fec74 off pre-up ethtool --set-priv-flags $IFACE fec91 on post-down ip link set $IFACE down allow-vnet xeth3

• Save the configs

• Run the following cmds to reload the interfaces & restart goes ifdown -a --allow vnet ifup -a --allow vnet goes restart

• Observed that interface speed has not updated to autoneg as it holds the previous configuration still under both ethtool & goes root@invader45:/home/sandeep/xeth_pp_testing# goes hget platina-mk1 speed |grep vnet.xeth3.speed vnet.xeth3.speed: 100g

root@invader45:/home/sandeep/xeth_pp_testing# ethtool xeth3 |grep Auto Auto-negotiation: off

• Reloaded platina-mk1 module along with networking & goes service restart rmmod platina-mk1 modprobe platina-mk1 provision=4,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1 service networking restart goes restart

• Speed has updated to autoneg on both redis & ethtool after running the above cmds.

root@invader45:/home/sandeep/xeth_pp_testing# ethtool xeth3 |grep Auto Auto-negotiation: on root@invader45:/home/sandeep/xeth_pp_testing# goes hget platina-mk1 speed |grep vnet.xeth3.speed vnet.xeth3.speed: autoneg

[sandeep-dutta]

Below is the configuration under /etc/modules-load.d/goesd-platina-mk1-modules.conf

i2c_i801

uio_pci_dma

platina-mk1 ixgbe ixgbevf options modprobe platina-mk1 provision=4,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1

Noticed that this issue occurs when you try shifting from autoneg off to autoneg on.

[sandeep-dutta]

Verified this on following goes & kernel version root@invader45:/home/sandeep/xeth_pp_testing# goes version github.com/platinasystems/go: v0.411-2-g14a8af4 github.com/platinasystems/fe1: v0.411 github.com/platinasystems/firmware-fe1a: v0.411

root@invader45:/home/sandeep/xeth_pp_testing# dpkg --list |grep kernel ii linux-image-4.13.0-platina-mk1 4.13-139-gace1518 amd64 Linux kernel, version 4.13.0-platina-mk1

[sandeep-dutta]

Noticed that issue the reproducible on the following GoES version

root@invader45:/home/sandeep/xeth_pp_testing_all_ports# goes version v1.2.0-rc.1