platisd / indoor-navigation-system

[WIP] An indoor navigation system to guide users towards their colleagues' desks
Apache License 2.0
15 stars 13 forks source link

Missing dependency to spdlog #57

Closed platisd closed 6 years ago

platisd commented 6 years ago

Description

Our current server/build.sh script does not build the server correctly unless spdlog is already installed in the system, which beats the purpose of including spdlog in our server/include/external directory. This slipped through as Travis does not build the server itself but just the tests.

Definition of Done

platisd commented 6 years ago

Originally reported by @lexious89

lexious89 commented 6 years ago

Okey! But I thought @samup4web commented out all references to spdlog.

platisd commented 6 years ago

Hmmm, not sure what you mean. There was indeed a problem. Have a look at #58 for the fix.

samup4web commented 6 years ago

@lexious89 I am not sure I understand you either. But, what I have done removing the dependency to spdlog was basically adding the source file to this project, and somehow introduced this issue which you experienced earlier.