Closed lexious89 closed 6 years ago
What issue does this pull request solve and what does it do in general?
Merging #95 into dev will increase coverage by
12.92%
. The diff coverage is100%
.
@@ Coverage Diff @@
## dev #95 +/- ##
===========================================
+ Coverage 71.14% 84.06% +12.92%
===========================================
Files 11 7 -4
Lines 499 364 -135
Branches 1 1
===========================================
- Hits 355 306 -49
+ Misses 144 58 -86
Impacted Files | Coverage Δ | |
---|---|---|
server/include/data_store.hpp | 100% <ø> (ø) |
:arrow_up: |
server/src/data_store.cpp | 86.79% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a0831be...4b4bd73. Read the comment docs.
I have updated the description and solved issues.
I also made some 'cosmetic changes' in the server/readme.md and some other files. These changes are trivial and only helped with debugging the localization alg. You may ignore these changes. They really don't add any value to the sw except for debugging purposes.
I understand that is a lot of code. I doubt if I would remember everything myself in a few months. A walk though would be good!
Is this ready to be reviewed again?
Yes, it is.
If more commits are to be added let me know when the request will be ready for review. Looks good now!
Okej. This should be the final commit for this branch. It is ready for review. ;)
Description
Localization algorithm for positioning and pathloss computation (rssi analytics) implementation in server.
Solved issue(s)
56 #7