search

platisd / nokia-5110-lcd-library

Arduino library for driving the Nokia 5110 LCD
MIT License
20 stars 7 forks source link

Adds draw method for bitmaps with defined width #17

Closed jnthas closed 3 years ago

jnthas commented 3 years ago

Hello Dimitris, I'm creating a new draw() method where we pass the bitmap width. That way, I can draw a bitmap of any size at any position without affecting other pixels around.

Original image: space

setCursor(0,4); IMG_20210806_204715

setCursor(65,0); IMG_20210806_204614

setCursor(0,0); IMG_20210806_204420

Let me know your thoughts.

jnthas commented 3 years ago

This PR resolves the issue #15

jnthas commented 3 years ago

There is a variable declared that is not being used, method print(unsigned long number) on line 336: const uint8_t base = 10; May I remove it?

platisd commented 3 years ago

I just merged a new compilation flag -Werror to be included when compiling the library on CI. This will help avoid forgotten unused variables like the one you mentioned. :)

jnthas commented 3 years ago

I just merged a new compilation flag -Werror to be included when compiling the library on CI. This will help avoid forgotten unused variables like the one you mentioned. :)

Great!

jnthas commented 2 years ago

Hi @platisd, just sharing the project I was working on using your library. Code will be available soon. https://youtube.com/playlist?list=PL2mlGAhto8F3rqkJ6roN0YaKJtBSbN_aq

platisd commented 2 years ago

Hi @platisd, just sharing the project I was working on using your library. Code will be available soon. https://youtube.com/playlist?list=PL2mlGAhto8F3rqkJ6roN0YaKJtBSbN_aq

Wow, I like the tunes 😁 What does the project do?

jnthas commented 2 years ago

Hi @platisd, just sharing the project I was working on using your library. Code will be available soon. https://youtube.com/playlist?list=PL2mlGAhto8F3rqkJ6roN0YaKJtBSbN_aq

Wow, I like the tunes 😁 What does the project do?

It's a synth/sequencer based on Arduino. You can make different kinds of music loops changing several parameters. It's pretty inspired on Pocket Operator. I suggest you take a look on YouTube about that, there are lots of videos about it.