search

platisd / nokia-5110-lcd-library

Arduino library for driving the Nokia 5110 LCD
MIT License
20 stars 7 forks source link

New method to control the backlight #3

Closed bubnov-mikhail closed 4 years ago

bubnov-mikhail commented 4 years ago

I have added a new constructor with a BL pin. That is an optional constructor and does not break anything.

The new method setBacklight(bool) allows to turn on/off the backlight. Why: I am passing a link to the LCD instance. And would like to control the backlight without having an additional pin number in my class.

platisd commented 4 years ago

There are some conflicts. I believe you will need to pull rebase from this master and then force push again.

bubnov-mikhail commented 4 years ago

Fixed

bubnov-mikhail commented 4 years ago

I have also renamed the inverted class member from the prev PR.

For the future PR, I am thinking about 2 new methods: sleep() and wakуUp(), both will send the native commands to the LCD to turn on/off power-save mode. What do you think?

platisd commented 4 years ago

I have also renamed the inverted class member from the prev PR.

I've commented on that separately. :grin:

For the future PR, I am thinking about 2 new methods: sleep() and wakуUp(), both will send the native commands to the LCD to turn on/off power-save mode. What do you think?

Sure. It's been a while since I've used this, but is there really a "sleep" feature for these screens? Wasn't it just about sending 0's?

bubnov-mikhail commented 4 years ago

kInverted fixed