search

platisd / skonaki

Create cheatsheets out of videos
MIT License
14 stars 2 forks source link

Add option to run whisper locally #2

Closed Marble879 closed 1 year ago

Marble879 commented 1 year ago

Changes

  1. Add a --run-whisper-locally optional flag.
  2. Add requirements-local-whisper.txt that includes the requirements from the base requirements.txt file.
  3. Use whisper locally based on if the --run-whisper-locally flag is set.

Screenshots

Running Whisper locally

image

Running Whisper via openAI API

image

Running Whisper locally without installing from requirements-local-whisper.txt

image

Issues

Resolves #1

platisd commented 1 year ago

Also, can you please update the README? Specifically the Installation part and whatever other places you think it's necessary.

Marble879 commented 1 year ago

Nice work! 🚀

Have you tried running it successfully?

Yes, I was able to run it successfully :blush: I've added screenshots to the PR description of the test runs I made.

Marble879 commented 1 year ago

Also, can you please update the README? Specifically the Installation part and whatever other places you think it's necessary.

The readme has now been updated :memo:

platisd commented 1 year ago

Thanks for the contribution! :rocket:

Marble879 commented 1 year ago

Thank you for the feedback and opportunity to contribute! :rocket: