cpplint warnings

[GoogleCodeExporter]

What steps will reproduce the problem?
1. cpplint.py --filter=-readability/casting source/*.cc include/libyuv/*.h

# libvpx cat's the files which brings out some additional include warnings, 
probably due to includes for intrinsics
cat source/row_win.cc | cpplint.py ...
2.
3.

What is the expected output? What do you see instead?
no lint warnings

What version of the product are you using? On what operating system?
r1041

Please provide any additional information below.

From: https://gerrit.chromium.org/gerrit/#/c/71151/

   third_party/libyuv/include/libyuv/mjpeg_decoder.h:156:  Do not leave a blank line after "private:"  [whitespace/blank_line] [3]
   third_party/libyuv/source/row_win.cc:14:  Found C system header after other header. Should be: -.h, c system, c++ system, other.  [build/include_order] [4]
   third_party/libyuv/source/row_win.cc:15:  Found C system header after other header. Should be: -.h, c system, c++ system, other.  [build/include_order] [4]
   third_party/libyuv/source/row_win.cc:81:  Redundant blank line at the start of a code block should be deleted.  [whitespace/blank_line] [2]
   third_party/libyuv/source/row_win.cc:135:  Redundant blank line at the start of a code block should be deleted.  [whitespace/blank_line] [2]
   third_party/libyuv/source/scale_argb.cc:13:  Found C system header after other header. Should be: -.h, c system, c++ system, other.  [build/include_order] [4]
   third_party/libyuv/source/scale_argb.cc:14:  Found C system header after other header. Should be: -.h, c system, c++ system, other.  [build/include_order] [4]
   third_party/libyuv/source/compare.cc:13:  Found C system header after other header. Should be: -.h, c system, c++ system, other.  [build/include_order] [4]
   third_party/libyuv/source/compare.cc:14:  Found C system header after other header. Should be: -.h, c system, c++ system, other.  [build/include_order] [4]

Original issue reported on code.google.com by jz...@google.com on 13 Aug 2014 at 5:59

[GoogleCodeExporter]

lol.  Is that the best bug you can find? :-)
I can't decide if I should mark this as priority low, or priority critical!

regular lint doesnt understand assembly, but we did improve the internal lint 
to skip over the inline blocks.
the code is in transition from c++/c99 to c89, so some warnings may crop in, 
but I'll do my best to keep it clean.
do we have a c89 lint?

Original comment by fbarch...@google.com on 14 Aug 2014 at 7:29

• Changed state: Started
• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

r1045 fixes blank lines.

I dont repro this warning?
third_party/libyuv/source/row_win.cc:81:  Redundant blank line at the start of 
a code block should be deleted. 

due to 'cat' these warnings
third_party/libyuv/source/scale_argb.cc:14:  Found C system header after other 
header. Should be: -.h, c system, c++ system, other.  
may not be fixable?

Original comment by fbarch...@google.com on 14 Aug 2014 at 7:45

[GoogleCodeExporter]

> do we have a c89 lint?

nope, thus the cat + filtering

> due to 'cat' these warnings
> third_party/libyuv/source/scale_argb.cc:14:  Found C system header after 
other header. Should be: -.h, c system, c++ system, other.  
> may not be fixable?

maybe not given the code structure.

Original comment by jz...@google.com on 14 Aug 2014 at 8:36

[GoogleCodeExporter]

On linux ubuntu precise this is before the fixes:

fbarchard@g36:/usr/local/google/libyuv/trunk$ cpplint.py 
--filter=-readability/casting source/*.cc include/libyuv/*.h
Done processing source/compare.cc
Done processing source/compare_common.cc
Done processing source/compare_neon.cc
Done processing source/compare_posix.cc
Done processing source/compare_win.cc
Done processing source/convert_argb.cc
Done processing source/convert.cc
Done processing source/convert_from_argb.cc
Done processing source/convert_from.cc
Done processing source/convert_jpeg.cc
Done processing source/convert_to_argb.cc
Done processing source/convert_to_i420.cc
Done processing source/cpu_id.cc
Done processing source/format_conversion.cc
source/mjpeg_decoder.cc:16:  Missing spaces around &&  [whitespace/operators] 
[3]
Done processing source/mjpeg_decoder.cc
Done processing source/mjpeg_validate.cc
Done processing source/planar_functions.cc
Done processing source/rotate_argb.cc
Done processing source/rotate.cc
Done processing source/rotate_mips.cc
Done processing source/rotate_neon.cc
Done processing source/row_any.cc
Done processing source/row_common.cc
Done processing source/row_mips.cc
Done processing source/row_neon.cc
Done processing source/row_posix.cc
source/row_win.cc:81:  Redundant blank line at the start of a code block should 
be deleted.  [whitespace/blank_line] [2]
source/row_win.cc:135:  Redundant blank line at the start of a code block 
should be deleted.  [whitespace/blank_line] [2]
Done processing source/row_win.cc
Done processing source/scale_argb.cc
Done processing source/scale.cc
Done processing source/scale_common.cc
Done processing source/scale_mips.cc
Done processing source/scale_neon.cc
Done processing source/scale_posix.cc
Done processing source/scale_win.cc
Done processing source/video_common.cc
Done processing include/libyuv/basic_types.h
Done processing include/libyuv/compare.h
Done processing include/libyuv/convert_argb.h
Done processing include/libyuv/convert_from_argb.h
Done processing include/libyuv/convert_from.h
Done processing include/libyuv/convert.h
Done processing include/libyuv/cpu_id.h
Done processing include/libyuv/format_conversion.h
include/libyuv/mjpeg_decoder.h:156:  Do not leave a blank line after "private:" 
 [whitespace/blank_line] [3]
Done processing include/libyuv/mjpeg_decoder.h
Done processing include/libyuv/planar_functions.h
Done processing include/libyuv/rotate_argb.h
Done processing include/libyuv/rotate.h
Done processing include/libyuv/row.h
Done processing include/libyuv/scale_argb.h
Done processing include/libyuv/scale.h
Done processing include/libyuv/scale_row.h
Done processing include/libyuv/version.h
Done processing include/libyuv/video_common.h
Total errors found: 4

Original comment by fbarch...@google.com on 15 Aug 2014 at 6:20

[GoogleCodeExporter]

Fixed in r1048

Original comment by fbarch...@google.com on 18 Aug 2014 at 11:23

• Changed state: Fixed