platoon-code / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Need J420ToABGR() implemented for SkCanvasVideoRenderer #470

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
https://code.google.com/p/chromium/codesearch#chromium/src/media/blink/skcanvas_
video_renderer.cc&l=530

Can be tested by copying YUVJ420 video to canvas:
https://code.google.com/p/chromium/codesearch#chromium/src/content/test/data/med
ia/blackwhite_yuvj420p.mp4

Original issue reported on code.google.com by dalecurtis@chromium.org on 24 Jul 2015 at 9:35

GoogleCodeExporter commented 9 years ago
adapting existing I420ToABGR to matrix function

set LIBYUV_WIDTH=640
set LIBYUV_HEIGHT=360
set LIBYUV_REPEAT=4000
out\release_x64\libyuv_unittest --gunit_also_run_disabled_tests 
--gtest_catch_exceptions=0 --gtest_filter=*I420ToARGB_*
test before on win64 (intrinsics)
I420ToARGB_Any (613 ms)
I420ToARGB_Unaligned (511 ms)
I420ToARGB_Invert (450 ms)
I420ToARGB_Opt (445 ms)

I420ToABGR is C
I420ToABGR_Any (4562 ms)
I420ToABGR_Invert (4447 ms)
I420ToABGR_Unaligned (4416 ms)
I420ToABGR_Opt (4410 ms)

and J420ToABGR does not exist.

Original comment by fbarch...@chromium.org on 2 Sep 2015 at 11:04

GoogleCodeExporter commented 9 years ago
J420ToABGR implemented in r1478

Original comment by fbarch...@chromium.org on 3 Sep 2015 at 6:36

GoogleCodeExporter commented 9 years ago
r1478 rolled into chromium.

In future, consider exposing 422 and 444 versions of this.
Followup - Test Neon version and switch to matrix style parameter.

Original comment by fbarch...@chromium.org on 3 Sep 2015 at 9:46