platz1de / EasyEdit

A feature-rich World Editor for PocketMine-MP
https://poggit.pmmp.io/p/EasyEdit/
GNU General Public License v3.0
42 stars 27 forks source link

Misuse of DiskResourceProvider #72

Closed dktapps closed 1 year ago

dktapps commented 1 year ago

https://github.com/platz1de/EasyEdit/blob/d02199edde9dc068dd26930c10ff3b83cec412d5/src/platz1de/EasyEdit/utils/RepoManager.php#L97

This is internal API and not intended for use by plugins.

There's no reason to use DiskResourceProvider here. A simple fopen($file, "rb") call would suffice.