plausible / analytics

Simple, open source, lightweight (< 1 KB) and privacy-friendly web analytics alternative to Google Analytics.
https://plausible.io
GNU Affero General Public License v3.0
19.69k stars 1.05k forks source link

Transfer ownership to invited user results in HTTP 500 #2640

Closed Popescu-PfeifferMarc closed 1 year ago

Popescu-PfeifferMarc commented 1 year ago

Past Issues Searched

Issue is a Bug Report

Using official Plausible Cloud hosting or self-hosting?

Self-hosting

Describe the bug

Transferring ownership to another user, who hasn't accepted the join request results in HTTP 500.

Expected behavior

An error message is shown, e.g. "this user hasn't accepted the join request".

Screenshots

No response

Environment

No response

ruslandoga commented 1 year ago

👋 @Popescu-PfeifferMarc

What Plausible version are you running?

A similar issue https://github.com/plausible/analytics/pull/2455 has been fixed in v1.5.

metmarkosaric commented 1 year ago

thanks for reporting @Popescu-PfeifferMarc! this happens on the cloud too when an invitation is sent to the same email address that's already on the pending invitation list. if you remove the person from the list of pending invitations first, you can invite them again without any problems. rather than showing a random error we should have a user friendly message instead saying something like:

You're trying to invite an email address that already has a pending invitation. Please remove the pending invitation before trying again

Popescu-PfeifferMarc commented 1 year ago

The issue was resolved by the invited user accepting the invite. I just wanted to suggest adding a more descriptive error message to help future users running into the same problem

Popescu-PfeifferMarc commented 1 year ago

👋 @Popescu-PfeifferMarc

What Plausible version are you running?

~A similar issue #2455 has been fixed in v1.5.~

It should be the latest release version of plausible (v1.5.1)