plausible / analytics

Simple, open source, lightweight (< 1 KB) and privacy-friendly web analytics alternative to Google Analytics.
https://plausible.io
GNU Affero General Public License v3.0
19.14k stars 1.03k forks source link

remove warning in migration #4133

Closed ruslandoga closed 1 month ago

ruslandoga commented 1 month ago

Changes

This PR removes some warnings that show up on new CE installations:

plausible-1            | Loading plausible..
plausible-1            | Starting dependencies..
plausible-1            | Starting repos..
plausible-1            | Running migrations for Elixir.Plausible.Repo
plausible-1            | Running migrations for Elixir.Plausible.IngestRepo
plausible-1            | warning: code block contains unused literal "Migration adds a ALIAS columns needed to keep DB schema and api\nproperty naming in sync to reduce overhead in code.\n" (remove the literal or assign it to _ to avoid warnings)
plausible-1            | └─ lib/plausible-0.0.1/priv/ingest_repo/migrations/20240502115822_alias_api_prop_names.exs: Plausible.IngestRepo.Migrations.AliasApiPropNames (module)
plausible-1            |
plausible-1            |     warning: variable "column_name" is unused (if the variable is not meant to be used, prefix it with an underscore)
plausible-1            |     │
plausible-1            |  56 │     for {alias_name, column_name} <- @sessions_prop_names do
plausible-1            |     │                      ~
plausible-1            |     │
plausible-1            |     └─ lib/plausible-0.0.1/priv/ingest_repo/migrations/20240502115822_alias_api_prop_names.exs:56:22: Plausible.IngestRepo.Migrations.AliasApiPropNames.down/0
plausible-1            |
plausible-1            |     warning: variable "column_name" is unused (if the variable is not meant to be used, prefix it with an underscore)
plausible-1            |     │
plausible-1            |  64 │     for {alias_name, column_name} <- @events_prop_names do
plausible-1            |     │                      ~
plausible-1            |     │
plausible-1            |     └─ lib/plausible-0.0.1/priv/ingest_repo/migrations/20240502115822_alias_api_prop_names.exs:64:22: Plausible.IngestRepo.Migrations.AliasApiPropNames.down/0
plausible-1            |
plausible-1            |     list-partitions Done!
plausible-1            |
plausible-1            | ------------------------------------------------------------------------------
plausible-1            |     get-sessions-table-settings Done!
plausible-1            |
plausible-1            | ------------------------------------------------------------------------------
plausible-1            |     drop-sessions-tmp-table Done!
plausible-1            |
plausible-1            | ------------------------------------------------------------------------------
plausible-1            |     create-sessions-tmp-table Done!
plausible-1            |
plausible-1            | ------------------------------------------------------------------------------
plausible-1            |     exchange-sessions-tables Done!
plausible-1            |
plausible-1            | ------------------------------------------------------------------------------
plausible-1            | Migration done!
plausible-1            | Migrations successful!

Tests

Changelog

Documentation

Dark mode