use nimble_csv everywhere

plausible / analytics

Simple, open source, lightweight (< 1 KB) and privacy-friendly web analytics alternative to Google Analytics.

https://plausible.io

GNU Affero General Public License v3.0

19.93k stars 1.06k forks source link

use nimble_csv everywhere #4183

Closed ruslandoga closed 2 months ago

ruslandoga commented 4 months ago

Changes

This PR replaces https://github.com/beatrichartz/csv with https://github.com/dashbitco/nimble_csv as a more performant option (fewer binaries are created this way)

Tests

[x] This PR does not require tests

Changelog

[x] This PR does not make a user-facing change

Documentation

[x] This change does not need a documentation update

Dark mode

[x] This PR does not change the UI

ukutaht commented 2 months ago

Hey @ruslandoga I'd like to merge this if possible. Why is it in draft status?

ruslandoga commented 2 months ago

The main reason is that I thought it would improve performance by using iolists but it turned out to be impossible since :zip.create only supports binaries. So I then marked it as Draft to make further changes to get rid of :zip.create and forgot. We can still merge it to remove the :csv dependency.

ruslandoga commented 2 months ago

I'll rebase the PR and remove the Draft tag.

github-actions[bot] commented 2 months ago

ruslandoga commented 2 months ago

CSV export worked for https://pr-4183.review.plausible.io/dummy.site