plausible / analytics

Simple, open source, lightweight (< 1 KB) and privacy-friendly web analytics alternative to Google Analytics.
https://plausible.io
GNU Affero General Public License v3.0
19.91k stars 1.06k forks source link

Minor refactor: Remove skip_refresh_imported_opts from query modifying functions #4204

Closed RobertJoonas closed 3 months ago

RobertJoonas commented 3 months ago

Changes

As pointed out by @macobo, some "include imported or not" logic is leaking into general query modifying functions and requires the developer to understand the logic behind it whenever doing operations such as remove_filters or set_property. This PR aims to avoid that, making it explicit and more close to the business logic where it's used.

I've also included comments in the relevant places and improved test coverage for timeseries.

Tests

Changelog

Documentation

Dark mode