search

plausible / analytics

Simple, open source, lightweight (< 1 KB) and privacy-friendly web analytics alternative to Google Analytics.
https://plausible.io
GNU Affero General Public License v3.0
19.89k stars 1.06k forks source link

Make new tab dashboard links work #4276

Closed aerosol closed 3 months ago

aerosol commented 3 months ago

I have no idea what I'm doing wrt react router, but this seems to work?

github-actions[bot] commented 3 months ago
|Preview environment👷🏼‍♀️🏗️ | |:-:| | [PR-4276](https://pr-4276.review.plausible.io)
github-actions[bot] commented 3 months ago
|Preview environment👷🏼‍♀️🏗️ | |:-:| | [PR-4276](https://pr-4276.review.plausible.io)
ukutaht commented 3 months ago

Ah, nice find with the basename prop. Seems to fix the linking issues indeed 👍

For shared links this should work: https://github.com/plausible/analytics/commit/3ba5a3c28547bbd5f7afbcdd6d5c9cc8ebb06006

aerosol commented 3 months ago

There's still some discrepancy between staging/preview and localhost. On localhost I'm getting duplicated domain fragment on left-clicks:

image

aerosol commented 3 months ago

@ukutaht how about 7190e7e?

ukutaht commented 3 months ago

@ukutaht how about 7190e7e?

Much better 👌