plausible / analytics

Simple, open source, lightweight (< 1 KB) and privacy-friendly web analytics alternative to Google Analytics.
https://plausible.io
GNU Affero General Public License v3.0
19.93k stars 1.06k forks source link

Generate goal filter SQL from postgres goals #4391

Closed ukutaht closed 2 months ago

ukutaht commented 2 months ago

With this PR we'll be generating the SQL for goal filters such that:

These changes are motivated by:

Also tagging @macobo because I think you should review this when you're back.

github-actions[bot] commented 2 months ago
|Preview environment👷🏼‍♀️🏗️ | |:-:| | [PR-4391](https://pr-4391.review.plausible.io)
ukutaht commented 2 months ago

@RobertJoonas Thanks for noticing the 500 error! Fixed in https://github.com/plausible/analytics/pull/4391/commits/e05ef3936559257648081e8a1eb8ceb991901744

aerosol commented 2 months ago

Will take me a while to understand what happened here, but I've been able to edit a goal's display name and it just worked. So thanks for sparing me that bit. <3