search

plausible / community-edition

Example Docker Compose setup for hosting Plausible Community Edition
1.28k stars 286 forks source link

Fix Nginx websocket config: proxy_pass is not inherited #127

Closed mebeim closed 4 months ago

mebeim commented 4 months ago

Whoops! Hit "create pull request" a bit too fast. The proxy_pass directive is not inherited in child location blocks and should be specified again.

ruslandoga commented 4 months ago

nginx config seems tricky :) It also seems like we can remove the need for reverse proxies in Plausible if we enable TLS and cert management there.

ruslandoga commented 4 months ago

Thank you!

mebeim commented 4 months ago

nginx config seems tricky :) It also seems like we can remove the need for reverse proxies in Plausible if we enable TLS and cert management there.

@ruslandoga true and true. However for the second point: the fact that putting services behind reverse-proxies like Nginx instead of exposing whatever other web server directly is pretty much industry standard is exactly because they are known to have a sane and well established TLS stack implementation, standard well-known architecture/configuration, good performance, etc. It also makes cert management easier (i.e., you update all your certs on the reverse proxy and don't have to worry about updating each cert for each service you host in a separately). Additionally, most people are already using reverse proxies regardless if they host multiple things on the same machine.

Not sure what you would be using internally for that, but definitely take the above into consideration.

Just my two cents, I am definitely not an expert!

Keep up the good work :smile: