Fix page reloads on missing hrefs

jozsefsallai commented 2 years ago

Added a check for the href attribute to the anchor link click event listener.

Description

Since the package updates the event listener of all anchor links on the website, sometimes we might not want the behavior of the new event listener to run. In this specific example, if an anchor tag doesn't have a href attribute, the page would just reload. Sometimes the lack of href tags is intentional. For example, the hamburger menu in Buefy's navigation component looks like this:

<a role="button" aria-label="menu" class="navbar-burger burger"> ... </a>

In this scenario, the hamburger anchor opens the menu but then the page reloads. My change makes sure the href attribute actually exists before doing anything.

Related Issue

N/A

Screenshots or GIFs (if appropriate):

N/A

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

obviyus commented 2 years ago

@ukutaht if you have a moment, it would be great to have this fix merged.

ionicsolutions commented 1 year ago

I ran into the exact same issue and would love for this to be merged so that we can enable outbound link tracking for our sites without breaking the mobile menu.

<a> tags without href are valid HTML but there is nothing to track there.

jozsefsallai commented 1 year ago

I ran into the exact same issue and would love for this to be merged so that we can enable outbound link tracking for our sites without breaking the mobile menu.

<a> tags without href are valid HTML but there is nothing to track there.

@ionicsolutions As a temporary workaround if you use Node.js tooling, you can use patch-package to manually fix the issue. The files you will likely need to patch are:

node_modules/plausible-tracker/build/main/lib/tracker.js
node_modules/plausible-tracker/build/module/lib/tracker.js

Adding the following line to the beginning of the trackClick function should fix the issue:

if (!this.href) return;

ionicsolutions commented 1 year ago

Thanks, @jozsefsallai, I implemented the workaround you suggested and it works like a charm.

plausible / plausible-tracker