plausible / plausible-tracker

Frontend library to interact with Plausible Analytics
https://github.com/plausible/plausible-tracker
MIT License
214 stars 46 forks source link

Don't access localStorage if it is not available #31

Closed Windvis closed 2 years ago

Windvis commented 2 years ago

Description

The changes introduced by https://github.com/plausible/plausible-tracker/pull/17 throw exceptions when localStorage is not available. Some browsers completely remove the localStorage key when certain settings are enabled (for example: "disable all cookies"). This adds an extra check to ensure localStorage is available before accessing it.

Related Issue

Fixes https://github.com/plausible/plausible-tracker/issues/25

Screenshots or GIFs (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #31 (879e8bc) into master (0369c0e) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           76        78    +2     
  Branches        19        22    +3     
=========================================
+ Hits            76        78    +2     
Impacted Files Coverage Δ
src/lib/request.ts 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

ukutaht commented 2 years ago

This is now released under 0.3.6