search

plausible / plausible-tracker

Frontend library to interact with Plausible Analytics
https://github.com/plausible/plausible-tracker
MIT License
214 stars 46 forks source link

Outbound link tracking prevents external links to open in new tab #38

Closed jaimeiniesta closed 2 years ago

jaimeiniesta commented 2 years ago

Versions

Describe the bug

When using enableAutoOutboundTracking, external links that have target="_blank" don't open in a new tab.

Expected behavior

The links should open in a new tab.

Steps to reproduce

Steps:

  1. Install normally
  2. Set it up like:
import Plausible from 'plausible-tracker'

const { enableAutoPageviews, enableAutoOutboundTracking } = Plausible({
    domain: 'example.com',
    trackLocalhost: false
  })

// This tracks the current page view and all future ones as well (for JS navigation)
enableAutoPageviews()

// This tracks outbound links
enableAutoOutboundTracking()
  1. Try clicking an external link like <a href="example.com" target="_blank">link</a>.

Your Environment

Additional context

Disabling enableAutoPageviews() makes it work fine again.

metmarkosaric commented 2 years ago

thanks for reporting @jaimeiniesta! this seems like a duplicate of https://github.com/plausible/plausible-tracker/issues/12

ukutaht commented 2 years ago

Thanks for reporting 🙏

Let's keep the discussion in #12. Subscribe to that issue for updates.