search

play-co / hookbox

HookBox is a Comet server and message queue that tightly integrates with your existing web application via web hooks and a REST interface.
http://hookbox.org
MIT License
284 stars 23 forks source link

create channel cb not called #55

Closed sylvain261 closed 14 years ago

sylvain261 commented 14 years ago

If I call subscribe on a non existing channel, the create_channel callback is never called. Protocol.py call server.get_channel witch create the channel without any call back to the web application. In fact, I don't know when this callback is used (except through the create channel rest api).

mcarter commented 14 years ago

I think you're right. line 267 of server.py should probably have needs_auth=True by default. I need to look and see what else that would affect though.

mcarter commented 14 years ago

pulled in fix from jordoh/hookbox, thanks!