search

play-co / timestep

GNU General Public License v3.0
16 stars 27 forks source link

ScrollView fixes #140

Closed heilhead closed 7 years ago

heilhead commented 7 years ago

BoxLayout.js: There's no such function. Apparently there was one in pre-es6 version (https://github.com/gameclosure/timestep/blob/master/src/ui/layout/BackingExtension.js#L167) - probably someone forgot to remove the reference.

ScrollView.js: I took a look at EverWing code and it looks like there's no use of auto-sizing anywhere, so this problem slipped under the radar. Basically, every time ScrollView's content was updated, the bounds were calculated incorrectly.

bchevalier commented 7 years ago

looks good made an analog PR on minicore: https://github.com/gameclosure/devkit-core/pull/80/files