search

play-co / timestep

GNU General Public License v3.0
16 stars 27 forks source link

Fix ScrollView inertia for the x axis bound region #48

Closed jishnu7 closed 8 years ago

jishnu7 commented 9 years ago

Fixes #220 in devkit.

collingreen commented 9 years ago

Thanks for this Jishnu -- I'll get to it as soon as I can.

collingreen commented 9 years ago

I haven't forgotten about this! Getting this tested and merged is still high on my todo list.

jishnu7 commented 9 years ago

One way to reproduce the bug and test is, in adventuremap module, scroll to the left end or right end, and then do a up/down swipe.

rogueSkib commented 8 years ago

I think with the minor change I mentioned above, and removing the additional file mode changes to the 3 files, this will be ready to merge.

jishnu7 commented 8 years ago

Should I revert file mod changes? 755 looks wrong to me.

rogueSkib commented 8 years ago

Hmm, ya the change seems correct, just was odd to have it in this PR in particular. Going ahead with the merge, thanks!