search

play-co / timestep

GNU General Public License v3.0
16 stars 27 forks source link

fix multi touch scroll #55

Closed jishnu7 closed 8 years ago

jishnu7 commented 9 years ago

Events should be re-enabled only after scroll animation is complete, otherwise user will be able to select elements in content view while inertia.

rogueSkib commented 8 years ago

@jishnu7 I'm a little unsure of the user experience here, we will probably want to test this first a bit before merging.

jishnu7 commented 8 years ago

What's happening was, when you scroll and release with multiple fingers, if any of your finger will touch a view which has an event attached to it, that event was triggering. If you know where the view will be after scroll, it is easy to reproduce.

Expected working should be, if user taps on screen during inertia, it should clear the animation and stop at that point.

The bug was happening because, blockEvents flag was released even before inertia completes.

rogueSkib commented 8 years ago

That makes sense, I'll give this a test run and then merge. Thanks again!