search

play-co / timestep

GNU General Public License v3.0
16 stars 27 forks source link

TextEditView: Soft keyboard now opens on first tap and cursor is positioned correctly. #71

Closed jsdevlover closed 8 years ago

collingreen commented 8 years ago

Thanks @jsdevlover. I'll try this out.

collingreen commented 8 years ago

@jsdevlover I'm not seeing either problem on my test phones without your changes (s4, android 4.4.4); iphone 5, ios9.1)

Can you tell me how to reproduce these issues so I can verify your changes fix them?

jsdevlover commented 8 years ago

@collingreen , you have already reproduced first part (opening keyboard on first click) and confirmed here (2nd bullet point in Android Summary).

For cursor position, type in some text in the TextEditView lose the focus and try refocusing TextEditView. This time the cursor is positioned before the text. It should be positioned at the end of the text.

Please let me know if these are fixed in any of the latest commits and if yes let me know the devkit-core version I should use. Thanks.

collingreen commented 8 years ago

You're right! I apparently have two textedit test apps - one shows these issues, the other does not. Digging into the differences now.

collingreen commented 8 years ago

More follow ups in the posted issue. tl;dr - 3 letter color codes seem to be an issue.

jsdevlover commented 8 years ago

Since we have identified the correct issue. I'm closing this PR.