Misc fixes

[mgh]

enable scrolling on landscape ios >= 7

Allows scrolling out the address bar when in an iphone mobile browser in the landscape orientation

By default we allow landscape scrolling in iOS 7+, but iOS 7 does not have friendly UX for landscape since tapping anywhere near the top or bottom of the screen will use make the navbar appear. Thus, for many games, it is desirable to leave the navbar open all the time on iOS 7 (even though the viewport will be very small), disabling scrolling completely. To disable scrolling, use Application._settings.minIOSLandscapeScroll to set the min version for which landscape scrolling. Set disableIOSLandscapeScroll to disable this feature completely.

src/Application:

  exports = Class(ui.View, function () {
    // disable ios landscape scrolling in iOS 7, only allow 8+
    this._settings = {
      minIOSLandscapeScroll: 8
    };
  });

Note that landscape scrolling is only relevant for web builds (iOS mobile safari) on iPhones (or iPods), not iPads and not standalone web browsers (e.g. home screen website or embedded web view).

misc fixes

• Image cache refactored from ImageView into separate file and shared with ImageScaleView
• default KeyListener removed (blocks key presses on a page with an embedded game)
• ui.resource.Image does nothing on render() if the error flag was set
• ImageScaleView 9slice corrects a negative middle slice size (try to render a best-attempt when the slices are larger than the image)

[mgh]

@rogueSkib @lunarraid can one of you review? adds one major feature for mobile browser builds and fixes 4 minor issues.

Sorry for the random fixes in there (I could make 5 pulls instead of 1 if that's easier). The commits are all self-contained though, so reviewing each commit is also possible.

[rogueSkib]

I reviewed each commit, looks good to me, Raymond is reviewing too and might add some notes.

On Wed, Dec 9, 2015 at 3:43 AM, Martin Hunt notifications@github.com wrote:

@rogueSkib https://github.com/rogueSkib @lunarraid https://github.com/lunarraid can one of you review? adds one major feature for mobile browser builds and fixes 4 minor issues.

Sorry for the random fixes in there (I could make 5 pulls instead of 1 if that's easier). The commits are all self-contained though, so reviewing each commit is also possible.

— Reply to this email directly or view it on GitHub https://github.com/gameclosure/timestep/pull/84#issuecomment-163198018.

Jimmy Griffith 704.309.2473 Studio Head @ Weeby.co http://www.weeby.co

[lunarraid]

As far as I can tell, this looks fine. Just remove line 435 in Image.js and it should be good.

[mgh]

thanks! updated that commit, merging now.