play2war / play2-war-plugin

WAR Plugin for Play framework 2.x
Apache License 2.0
443 stars 71 forks source link

Play Framework 2.5 support is needed #308

Open realzeus opened 8 years ago

realzeus commented 8 years ago

play2war currently does not support play 2.5.

masudjbd commented 8 years ago

when play 2.5 version will be available?

victorjussiani commented 8 years ago

+1

litts commented 8 years ago

+1 upgraded to 2.5 but can't deploy to client have to revert back

pdenc commented 8 years ago

When play 2.5 version will be available?

mwiley63 commented 8 years ago

+1 I would really like to utilize the custom logging framework in 2.5 in a Tomcat environment. https://www.playframework.com/documentation/2.5.x/SettingsLogger#using-a-custom-logging-framework

kbarzen-idn commented 8 years ago

Any idea when it's compatible with Play 2.5? Is it already scheduled?

yanns commented 8 years ago

Thanks all of us for manifesting interest! The play2war is completely depending on free time of some people (like me). I do not have the time/motivation to make this change now. If one of you want to try, I'd be glad to assist.

cyrilfr commented 7 years ago

@yanns Hi, I could try to do it depending on how much work it represents.

yanns commented 7 years ago

@cyrilfr thx for the proposition. Look at https://github.com/play2war/play2-war-plugin/wiki/How-to-help for some general information.

How you can proceed:

To improve project_code, you can have a look at the sources of the play framework, especially:

The servlet 3.1 implementation is an optimized version (using non blocking IO) and can be done at the end: https://github.com/play2war/play2-war-plugin/commit/dae86f01dc38a5fc4f330774fbd5287eab416cf8#diff-6631fbdeb8bfe668903b928d15152696L153

For a faster iteration loop, you can use the aliases defined in https://github.com/play2war/play2-war-plugin/blob/308_play_2.5/project-code/.sbtrc In my experience, in sample, you have to exit sbt to be able to use the last version.

at-tantv commented 7 years ago

I need it now, so when you free time you can support for me

jroper commented 6 years ago

For anyone wishing to take this up, I've implemented a servlet 3.1 based reactive streams implementation that can be used to bridge to Akka streams in Play 2.5. I've verified it against both Tomcat and Jetty.

yanns commented 6 years ago

Thanks a lot @jroper !!

To whoever is interested, it should be much easier now to bind play and a servlet container. I can offer some support.

pwyczes commented 6 years ago

Hi there, I started to work on #321 (play 2.6) so if anyone is willing to help me with that (or at least comment if I am moving in the right direction), I will be more than happy. :)

PS. Thanks @yanns for your work on play 2.5 - it helped me a lot.

pwyczes commented 6 years ago

Hi @yanns, as I wrote, I am working on #321 (play 2.6). If you still can offer some support, maybe you can give me some hints on https://github.com/play2war/play2-war-plugin/pull/323 ;) I would appreciate.