play4honor / discord_quote_bot

A bot that brings the "quote" feature to Discord.

2 stars 1 forks source link

Make it possible to quote the URL link instead of the ID #56

Closed zhangchuck closed 4 years ago

zhangchuck commented 4 years ago

Summary

ID requires dev mode and is sometimes inaccessible even with dev mode on mobile
URL has all the info we would need to quote a message
Could also use this to do cross-channel quoting

Functionality

Copy message link of the message that you want to quote
Type !q [message link] or !q[message link] [reply] and get quote functionality

Example:

!q https://discord.com/channels/106536439809859584/106536439809859584/749366987230150667
!q https://discord.com/channels/106536439809859584/106536439809859584/749366987230150667 Wow, what an ass...

Suggested Implementation

Add a conditional branch in the quote function. The first argument should be either all digits or a valid Discord URL.
If it's a valid Discord URL, do a tiny bit of parsing to get the message id

zhangchuck commented 4 years ago

Could add the conditional here. Check if msg_id is a Discord-style URL. If it is, pull out the last element (which is the message ID)

https://github.com/play4honor/discord_quote_bot/blob/162506da27eda21dbc663a87722915cc6a037432/discord_quote/discord_quote/discord_quote.py#L133-L135